Flagship/abox-mgr
5
2
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(about): add link buttons and logo rounding #16

Merged
KremeCN merged 1 commits from feat/about-page-links into main 2026-08-28 11:19:44 +08:00
Conversation 2 Commits 1 Files Changed 4
+57 -6
KremeCN commented 2026-08-28 11:14:50 +08:00
Owner
Copy Link
Copy Source

Summary

  • add rounded corners to the About page logo
  • add GitHub profile links for KremeCN, Moler, and alZerNest
  • add personal website links for KremeCN and Moler
  • localize link content descriptions in English and Simplified Chinese

Verification

  • debug build completed successfully
  • APK installed on emulator
## Summary - add rounded corners to the About page logo - add GitHub profile links for KremeCN, Moler, and alZerNest - add personal website links for KremeCN and Moler - localize link content descriptions in English and Simplified Chinese ## Verification - debug build completed successfully - APK installed on emulator
KremeCN added 1 commit 2026-08-28 11:14:50 +08:00
feat(about): add link buttons and logo rounding b79b5b86db
pr-agent-bot bot reviewed 2026-08-28 11:15:25 +08:00
pr-agent-bot bot left a comment
Copy Link
Copy Source

Inline comment

Inline comment
android/app/src/main/kotlin/com/flagship/abox/manager/ui/about/AboutScreen.kt
@@ -191,5 +191,5 @@
if (githubUrl != null) {
Icon(
painter = painterResource(R.drawable.ic_github),
contentDescription = stringResource(R.string.about_link_github),
modifier = Modifier
pr-agent-bot bot commented 2026-08-28 11:15:25 +08:00
Copy Link
Copy Source

触控过小

两个链接仅将 18dp 的图标本身设为可点击区域，远小于 Android 建议的至少 48dp 触控目标，用户在触屏或无障碍操作中会难以准确点击。请使用 IconButton 或至少 48dp 的可点击容器承载图标，并保留当前的内容描述。

**触控过小** 两个链接仅将 18dp 的图标本身设为可点击区域，远小于 Android 建议的至少 48dp 触控目标，用户在触屏或无障碍操作中会难以准确点击。请使用 `IconButton` 或至少 48dp 的可点击容器承载图标，并保留当前的内容描述。 <!-- pr-agent-dedup: a51b3901905a --> <!-- pr-agent-key-issue-location: 3dab802ae3ed -->
pr-agent-bot bot reviewed 2026-08-28 11:15:26 +08:00
pr-agent-bot bot left a comment
Copy Link
Copy Source

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
## PR Reviewer Guide 🔍 Here are some key observations to aid the review process: <table> <tr><td>⏱️&nbsp;<strong>Estimated effort to review</strong>: 2 🔵🔵⚪⚪⚪</td></tr> <tr><td>🧪&nbsp;<strong>No relevant tests</strong></td></tr> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> </table>
KremeCN merged commit 1238b82b4a into main 2026-08-28 11:19:44 +08:00
KremeCN deleted branch feat/about-page-links 2026-08-28 11:19:44 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
pr-agent-bot
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Aurum KremeCN Moler alZerNest pr-agent-bot tzh
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Flagship/abox-mgr#16